GH-50519: [C++][FlightRPC][ODBC] Add missing ARROW_FLIGHT_SQL_ODBC_INSTALLER option entry - #50520
Merged
Conversation
…ODBC_INSTALLER` option entry
|
|
github-actions
Bot
added
Component: C++
awaiting committer review
Member
Author
|
@alinaliBQ @justing-bq Could you take a look at this? |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 9a8b200. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We must define options explicitly.
What changes are included in this PR?
ARROW_FLIGHT_SQL_ODBC_INSTALLERtoDefineOptions.cmakeARROW_FLIGHT_SQL_ODBC_INSTALLERby default infeatures-maximalpreset because it's available only on Windows and macOSAre these changes tested?
Yes.
Are there any user-facing changes?
Yes.
ARROW_FLIGHT_SQL_ODBC_INSTALLERoption entry is missing #50519